Don't call preventDefault() if the hotkey-fire event has been cancelled #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keithamus
approved these changes
Apr 10, 2024
mattcosta7
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've ran into the issue that hotkeys are still triggered if the element is not clickable/accessible.
In our case the button is covered by the scrim of a dialog.
We use the hotkey-fire event to call preventDefault() on the hotkey event, but we want the original key event to still go through. This currently doesn't work as this library always calls preventDefault after firing the hotkey-fire event, even if the hotkey-fire event is cancelled.
This PR changes this behaviour to no longer prevent the key event if hotkey-fire event is cancelled.